Re: [PATCH V10 1/8] dt-bindings: spi: Add sc7280 support

[rajpat]

On 2021-09-25 04:17, Bjorn Andersson wrote:
> On Thu 23 Sep 07:16 CDT 2021, Rajesh Patil wrote:
>
> > Add compatible for sc7280 SoC.
> >
> > Signed-off-by: Rajesh Patil <rajpat@xxxxxxxxxxxxxx>
> > Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
>
> Can you please pick up Rob's review tag and send this patch out again,
> this time including the SPI maintainer (Mark Brown 
> <broonie@xxxxxxxxxx>)
> among the recipients.
>
> Thanks,
> Bjorn

Okay.

> > ---
> > Change in V10:
> >  - As per Stephen's comments,
> >    sorted compatible names in alphabet order
> >
> > Changes in V9:
> >  - No changes
> >
> > Changes in V8:
> >  - As per Doug's comments, added "qcom,sc7280-qspi" compatible
> >
> >  Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 
> > ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml 
> > b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> > index ef5698f..09aa955 100644
> > --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> > @@ -21,7 +21,10 @@ allOf:
> >  properties:
> >    compatible:
> >      items:
> > -      - const: qcom,sdm845-qspi
> > +      - enum:
> > +          - qcom,sc7280-qspi
> > +          - qcom,sdm845-qspi
> > +
> >        - const: qcom,qspi-v1
> >
> >    reg:
> > --
> > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
> > member
> > of Code Aurora Forum, hosted by The Linux Foundation