Re: [PATCH -next] memory: tegra186-emc: Fix error return code in tegra186_emc_probe()

From: Mikko Perttunen
Date: Mon Sep 27 2021 - 04:53:04 EST

On 9/27/21 10:51 AM, Yang Yingliang wrote:
Return the error code when command fails.

Fixes: 13324edbe926 ("memory: tegra186-emc: Handle errors in BPMP response")
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
drivers/memory/tegra/tegra186-emc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/tegra186-emc.c
index abc0c2eeaab7..16351840b187 100644
--- a/drivers/memory/tegra/tegra186-emc.c
+++ b/drivers/memory/tegra/tegra186-emc.c
@@ -198,6 +198,7 @@ static int tegra186_emc_probe(struct platform_device *pdev)
goto put_bpmp;
if (msg.rx.ret < 0) {
+ err = msg.rx.ret;
dev_err(&pdev->dev, "EMC DVFS MRQ failed: %d (BPMP error code)\n", msg.rx.ret);
goto put_bpmp;

Good catch, but we shouldn't return msg.rx.ret since it is a BPMP error code that doesn't necessarily map directly to a Linux error code. So we should set err to something like -EINVAL instead. Please update, or if you'd prefer, I can fix it.