About the "__refdata" tag in pci-keystone.c
From: Sergio M. Iglesias
Date: Mon Sep 27 2021 - 06:41:21 EST
Hello!
I have checked the "__refdata" tag that appears in the file
"drivers/pci/controller/dwc/pci-keystone.c" and it is needed. The tag has
been there since the creation of the file on commit 6e0832fa432e and
nothing has changed since that would make it redundant.
The reason it is needed is because the struct references "ks_pcie_probe",
which is a function tagged as "__init", so the compiler will most likely
complain about the "__refdata" being removed.
Should I send a patch to add a comment explaining why it is a necessary
tag as recommended in "include/linux/init.h"?
> [...] so optimally document why the __ref is needed and why it's OK).
Thanks for your time,
Sergio M. Iglesias.