Re: [PATCH] gpu: host1x: select CONFIG_DMA_SHARED_BUFFER

[Mikko Perttunen]

On 9/27/21 12:36 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Linking fails when dma-buf is disabled:
>
> ld.lld: error: undefined symbol: dma_fence_release
> > > > referenced by fence.c
> > > >                gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
> > > > referenced by fence.c
> > > >                gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
> > > > referenced by fence.c
> > > >                gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a
>
> Fixes: 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>   drivers/gpu/host1x/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> index 6dab94adf25e..6815b4db17c1 100644
> --- a/drivers/gpu/host1x/Kconfig
> +++ b/drivers/gpu/host1x/Kconfig
> @@ -2,6 +2,7 @@
>   config TEGRA_HOST1X
>   	tristate "NVIDIA Tegra host1x driver"
>   	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
> +	select DMA_SHARED_BUFFER
>   	select IOMMU_IOVA
>   	help
>   	  Driver for the NVIDIA Tegra host1x hardware.

Thanks!

Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>