Re: [PATCH net-next] ptp: add vclock timestamp conversion IOCTL

[Richard Cochran]

On Mon, Sep 27, 2021 at 11:32:50AM +0200, Sebastien Laveze wrote:
> Add an IOCTL to perform per-timestamp conversion, as an extension of the
> ptp virtual framework introduced in commit 5d43f951b1ac ("ptp: add ptp
> virtual clock driver framework").

I'm not wild about having yet another ioctl for functionality that
already exists.

> This binding works well if the application requires all timestamps in the
> same domain but is not convenient when multiple domains need to be
> supported using a single socket.

Opening multiple sockets is not rocket science.
 
> Typically, IEEE 802.1AS-2020 can be implemented using a single socket,
> the CMLDS layer using raw PHC timestamps and the domain specific
> timestamps converted in the appropriate gPTP domain using this IOCTL.

You say "typically", but how many applications actually do this?  I
can't think of any at all.

Thanks,
Richard