Re: [PATCH 3/4] arm64: dts: marvell: espressobin-ultra: add PHY and switch reset pins

From: Andrew Lunn
Date: Mon Sep 27 2021 - 12:38:11 EST


On Mon, Sep 27, 2021 at 05:41:58PM +0200, Robert Marko wrote:
> Both the Topaz switch and 88E1512 PHY have their reset and interrupts
> connected to the SoC.
>
> So, define the Topaz and 88E1512 reset pins in the DTS.
>
> Defining the interrupt pins wont work as both the 88E1512 and the
> Topaz switch uses active LOW IRQ signals but the A37xx GPIO controller
> only supports edge triggers.
> 88E1512 would require special setup anyway as its INT pin is shared with
> the LED2 and you first need to configure it as INT.
>
> Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew