Re: [PATCH] Documentation: checkpatch: Document some more message types
From: Utkarsh Verma
Date: Mon Sep 27 2021 - 13:52:08 EST
On Mon, Sep 27, 2021 at 11:43:59AM -0600, Jonathan Corbet wrote:
> Utkarsh Verma <utkarshverma294@xxxxxxxxx> writes:
> > Added and documented 3 new message types:
> > - UNNECESSARY_INT
> > - UNSPECIFIED_INT
> > - UNNECESSARY_ELSE
> > Signed-off-by: Utkarsh Verma <utkarshverma294@xxxxxxxxx>
> > ---
> > Documentation/dev-tools/checkpatch.rst | 47 ++++++++++++++++++++++++++
> > 1 file changed, 47 insertions(+)
> So...when you send multiple patches with the same subject line that's
> always a bad sign. We really want a "git --oneline" listing to give a
> good idea of what the patch does, and that depends on more descriptive
> subject lines.
> In this case, something like:
> docs: checkpatch: add UNNECESSARY/UNSPECIFIED_INT and UNNECESSARY_ELSE
> I can fix up these two patches, but please try to keep this in mind for
> future work.
Alright, I will keep this in mind.
> (applying the patches now).