Re: [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger

From: Rob Herring
Date: Mon Sep 27 2021 - 15:52:53 EST


On Thu, Sep 23, 2021 at 03:54:52PM +0900, Daniel Palmer wrote:
> The "activity" trigger can be used as the default but it's currently
> undocumented so validating a devicetree that uses it causes a warning.

It is preferred to use 'function' and LED_FUNCTION_CPU. Is there some
reason that can't be used?

>
> Signed-off-by: Daniel Palmer <daniel@xxxxxxxx>
> ---
> Documentation/devicetree/bindings/leds/common.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 697102707703..8160a5073728 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -80,6 +80,8 @@ properties:
> $ref: /schemas/types.yaml#/definitions/string
>
> enum:
> + # LED will flashing will represent current CPU usage
> + - activity
> # LED will act as a back-light, controlled by the framebuffer system
> - backlight
> # LED will turn on (but for leds-gpio see "default-state" property in
> --
> 2.33.0
>
>