Re: [PATCH v2 1/3] drm/rockchip: dsi: Hold pm-runtime across bind/unbind
From: Brian Norris
Date: Mon Sep 27 2021 - 15:57:50 EST
On Mon, Sep 27, 2021 at 12:18 PM Tom Hebb <tommyhebb@xxxxxxxxx> wrote:
> Reviewed-by: Thomas Hebb <tommyhebb@xxxxxxxxx>
> Thank you for catching this, and sorry that my original fix broke things.
> There had actually been a report of this breakage from my patch, but I
> missed that email until it had already been merged and then didn't have
> time to follow up on it. Totally my bad.
No worries. It was a 1 step forward, 1 step backward kind of a thing
anyway -- things were broken in many cases before your patch too (with
very similar-looking symptoms) -- so the net result is still good,
having both issues fixed.
I'm not sure how that ideally should have been handled , but it's
totally fair to not have time to follow up on everything. At the
worst, we could have reverted things; but again, I'm pretty sure
things were broken just as well without your fix, just with a
different root cause.
 Don't accept (or, revert?) your bugfix until what may or may not
have been a regression is fixed? I'm not sure.