RE: [PATCH] igc: fix PTP dependency

From: Keller, Jacob E
Date: Mon Sep 27 2021 - 18:35:42 EST




> -----Original Message-----
> From: Arnd Bergmann <arnd@xxxxxxxxxx>
> Sent: Monday, September 27, 2021 6:17 AM
> To: Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>; Keller, Jacob E
> <jacob.e.keller@xxxxxxxxx>; Saleem, Shiraz <shiraz.saleem@xxxxxxxxx>; Kurt
> Kanzenbach <kurt@xxxxxxxxxxxxx>; Ertman, David M
> <david.m.ertman@xxxxxxxxx>; Shannon Nelson <snelson@xxxxxxxxxxx>;
> Richard Cochran <richardcochran@xxxxxxxxx>; Vladimir Oltean
> <vladimir.oltean@xxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] igc: fix PTP dependency
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The igc driver was accidentally left out of the Kconfig rework for PTP,
> it needs the same dependency as the others:
>
> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_main.o: in function
> `igc_tsync_interrupt':
> igc_main.c:(.text+0x1b288): undefined reference to `ptp_clock_event'
> arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b308): undefined reference to
> `ptp_clock_event'
> arm-linux-gnueabi-ld: igc_main.c:(.text+0x1b8cc): undefined reference to
> `ptp_clock_event'
> arm-linux-gnueabi-ld: drivers/net/ethernet/intel/igc/igc_ethtool.o: in function
> `igc_ethtool_get_ts_info':
>
> Fixes: e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks!

-Jake

> ---
> drivers/net/ethernet/intel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/Kconfig
> b/drivers/net/ethernet/intel/Kconfig
> index b0b6f90deb7d..ed8ea63bb172 100644
> --- a/drivers/net/ethernet/intel/Kconfig
> +++ b/drivers/net/ethernet/intel/Kconfig
> @@ -335,6 +335,7 @@ config IGC
> tristate "Intel(R) Ethernet Controller I225-LM/I225-V support"
> default n
> depends on PCI
> + depends on PTP_1588_CLOCK_OPTIONAL
> help
> This driver supports Intel(R) Ethernet Controller I225-LM/I225-V
> family of adapters.
> --
> 2.29.2