Re: [RFC PATCH 06/13] x86/uintr: Introduce uintr receiver syscalls

[Sohil Mehta]

On 9/23/2021 5:26 AM, Greg KH wrote:
> On Mon, Sep 13, 2021 at 01:01:25PM -0700, Sohil Mehta wrote:
> > +
> > +/* User Posted Interrupt Descriptor (UPID) */
> > +struct uintr_upid {
> > +	struct {
> > +		u8 status;	/* bit 0: ON, bit 1: SN, bit 2-7: reserved */
> > +		u8 reserved1;	/* Reserved */
> > +		u8 nv;		/* Notification vector */
> > +		u8 reserved2;	/* Reserved */
> What are these "reserved" for?


The UPID is an architectural data structure defined by the hardware. The 
reserved fields are defined by the hardware (likely to keep the 
structure size as 16 bytes).


> > +struct uintr_upid_ctx {
> > +	struct uintr_upid *upid;
> > +	refcount_t refs;
> Please use a kref for this and do not roll your own for no good reason.

Sure. Will do.