Re: [PATCH] [RFC] mtd: fixup CFI on ixp4xx

From: Linus Walleij
Date: Mon Sep 27 2021 - 19:27:57 EST

On Mon, Sep 27, 2021 at 4:10 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:

> From: Arnd Bergmann <arnd@xxxxxxxx>
> drivers/mtd/maps/ixp4xx.c requires MTD_CFI_BE_BYTE_SWAP to be set
> in order to compile.
> drivers/mtd/maps/ixp4xx.c:57:4: error: #error CONFIG_MTD_CFI_BE_BYTE_SWAP required
> This patch avoids the #error output by enforcing the policy in
> Kconfig. Not sure if this is the right approach, but it helps doing
> randconfig builds.
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> Any other ideas for how to address it?

We will "soon" have IXP4xx transitioned to device tree and then
physmap-ixp4xx.c is used instead, and this entire driver can be
deleted. I will get there, we just need to remember to mop of cruft
like this at the end of it.

Linus Walleij