Re: [PATCH 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe()

[Cai Huoqing]

On 27 9月 21 22:09:47, Martin Blumenstingl wrote:
> Hello,
> 
> first of all: thanks for this patch!
> 
> On Mon, Sep 27, 2021 at 10:15 AM Cai Huoqing <caihuoqing@xxxxxxxxx> wrote:
> [...]
> > +       if (IS_ERR(priv->clkin))
> > +               return dev_err_probe(&pdev->dev,
> > +                                    PTR_ERR(priv->clkin),
> Is there any specific reason why you put PTR_ERR() on a separate line?
> it would still fit into the line above and be below the old 80 chars
> per line limit.
> For priv->vref you already have it the way I am suggesting there.
> 
> [...]
> > +       if (IS_ERR(priv->core_clk))
> > +               return dev_err_probe(&pdev->dev,
> > +                                    PTR_ERR(priv->core_clk),
> the same question as above applies here as well
> 
> 
> Best regards,
> Martin
Hi,

Thanks for your feedback.
I have resend v2 to fix it.
here
https://lore.kernel.org/linux-arm-kernel/20210928013621.1245-6-caihuoqing@xxxxxxxxx/

Many thanks
Cai