Re: [PATCH] s390/sclp_vt220: fix unused function warning

From: Heiko Carstens
Date: Tue Sep 28 2021 - 04:33:07 EST


On Mon, Sep 27, 2021 at 02:56:47PM -0700, Randy Dunlap wrote:
> When CONFIG_SCLP_VT220_TTY=y and CONFIG_SCLP_VT220_CONSOLE is not set:
>
> ../drivers/s390/char/sclp_vt220.c:771:13: warning: '__sclp_vt220_flush_buffer' defined but not used [-Wunused-function]
> 771 | static void __sclp_vt220_flush_buffer(void)
>
> so move this function inside the #ifdef block where it is used.
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Heiko Carstens <hca@xxxxxxxxxxxxx>
> Cc: Vasily Gorbik <gor@xxxxxxxxxxxxx>
> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> Cc: linux-s390@xxxxxxxxxxxxxxx
> ---
> Sorry, I can't determine what the Fixes: tag for this should be
> (missing some git fu).

It's not worth spending time to figure this out.

Applied, thanks!