Re: [PATCH 1/2] regulator: Add Unisoc's SC2730 regulator driver

[Mark Brown]

On Tue, Sep 28, 2021 at 03:36:08PM +0800, Chunyan Zhang wrote:

> +++ b/drivers/regulator/sc2730-regulator.c
> @@ -0,0 +1,502 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2018-2021 Unisoc Inc.
> + */

Please make the entire comment a C++ one so things look more
intentional.

> +static int debugfs_enable_get(void *data, u64 *val)
> +{
> +	struct regulator_dev *rdev = data;
> +

> +static int debugfs_enable_set(void *data, u64 val)
> +{
> +	struct regulator_dev *rdev = data;
> +

> +static int debugfs_voltage_get(void *data, u64 *val)
> +{

> +static int debugfs_voltage_set(void *data, u64 val)
> +{

If these were to be implemented they should be in the core as there's
nothing device specific about them (the read side is there), please
remove them from the driver.

> +static const struct of_device_id sc2730_regulator_match[] = {
> +	{ .compatible = "sprd,sc2730-regulator" },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, sc2730_regulator_match);

Since this is a part of a MFD I'd not expect it to have a compatible
string?

Attachment: signature.asc
Description: PGP signature