Re: [PATCH -next v2] memory: tegra186-emc: Fix error return code in tegra186_emc_probe()
From: Mikko Perttunen
Date: Tue Sep 28 2021 - 08:30:13 EST
On 9/28/21 5:15 AM, Yang Yingliang wrote:
Return the error code when command fails.
Fixes: 13324edbe926 ("memory: tegra186-emc: Handle errors in BPMP response")
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
---
drivers/memory/tegra/tegra186-emc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/tegra186-emc.c
index abc0c2eeaab7..746c4ef2c0af 100644
--- a/drivers/memory/tegra/tegra186-emc.c
+++ b/drivers/memory/tegra/tegra186-emc.c
@@ -198,6 +198,7 @@ static int tegra186_emc_probe(struct platform_device *pdev)
goto put_bpmp;
}
if (msg.rx.ret < 0) {
+ err = -EINVAL;
dev_err(&pdev->dev, "EMC DVFS MRQ failed: %d (BPMP error code)\n", msg.rx.ret);
goto put_bpmp;
}
Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>