Re: [PATCH v2 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe()

From: Linus Walleij
Date: Tue Sep 28 2021 - 09:47:40 EST


On Tue, Sep 28, 2021 at 3:36 AM Cai Huoqing <caihuoqing@xxxxxxxxx> wrote:

> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> Signed-off-by: Cai Huoqing <caihuoqing@xxxxxxxxx>
> ---
> v1->v2: Remove the separate line of PTR_ERR().

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij