Re: [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

[khsieh]

On 2021-08-27 10:14, Bjorn Andersson wrote:
> On Fri 27 Aug 00:20 CDT 2021, Stephen Boyd wrote:
>
> > Quoting Bjorn Andersson (2021-08-25 16:42:31)
> > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> > > index 2c7de43f655a..4a6132c18e57 100644
> > > --- a/drivers/gpu/drm/msm/dp/dp_display.c
> > > +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> > > @@ -78,6 +78,8 @@ struct dp_display_private {
> > >         char *name;
> > >         int irq;
> > >
> > > +       int id;
> > > +
> > >         /* state variables */
> > >         bool core_initialized;
> > >         bool hpd_irq_on;
> > > @@ -115,8 +117,19 @@ struct dp_display_private {
> > >         struct dp_audio *audio;
> > >  };
> > >
> > > +
> > > +struct msm_dp_config {
> > > +       phys_addr_t io_start[3];
> >
> > Can this be made into another struct, like msm_dp_desc, that also
> > indicates what type of DP connector it is, i.e. eDP vs DP? That would
> > help me understand in modetest and /sys/class/drm what sort of 
> > connector
> > is probing. dp_drm_connector_init() would need to pass the type of
> > connector appropriately. Right now, eDP connectors still show up as DP
> > instead of eDP in sysfs.
>
> I like it, will spin a v3 with this.
>
> Regards,
> Bjorn

Hi Bjorn,

Have you spin off V3 yet?
When you expect your patches related to DP be up streamed?

Thanks,
kuogee
> > > +       size_t num_dp;
> > > +};
> > > +
> > > +static const struct msm_dp_config sc7180_dp_cfg = {
> > > +       .io_start = { 0x0ae90000 },
> > > +       .num_dp = 1,
> > > +};
> > > +
> > >  static const struct of_device_id dp_dt_match[] = {
> > > -       {.compatible = "qcom,sc7180-dp"},
> > > +       { .compatible = "qcom,sc7180-dp", .data = &sc7180_dp_cfg },
> > >         {}
> > >  };
> > >