Re: [PATCH v3 0/4] PCI/ACPI: Simplify PCIe _OSC feature negotiation
From: Bjorn Helgaas
Date: Tue Sep 28 2021 - 17:21:26 EST
On Tue, Aug 24, 2021 at 02:20:50PM +0200, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@xxxxxxx>
> here is the third version of my patches to simplify the _OSC
> negotiation of PCIe features between Linux and the firmware.
> This version is a complete rewrite, so there is no changelog to the
> previous version. Patches 1-3 are cleanups and small restructurings of
> the code as a preparation for patch 4.
> The last patch gets rid of the dedicated _OSC query to check for _OSC
> support and merges that functionality into acpi_pci_osc_control_set().
> This allows to simplify and/or remove other functions and consilidate
> error handling in negotiate_os_control().
> I have tested the patches with and without 'pcie_ports=compat' and
> found no regressions on my test machine.
> Please review.
> Joerg Roedel (4):
> PCI/ACPI: Remove OSC_PCI_SUPPORT_MASKS and OSC_PCI_CONTROL_MASKS
> PCI/ACPI: Move supported and control calculations to separaten
> PCI/ACPI: Move _OSC query checks to separate function
> PCI/ACPI: Check for _OSC support in acpi_pci_osc_control_set()
> drivers/acpi/pci_root.c | 161 +++++++++++++++++++++-------------------
> include/linux/acpi.h | 2 -
> 2 files changed, 84 insertions(+), 79 deletions(-)
Applied with Rafael's reviewed-by to pci/acpi for v5.16, thanks!