RE: [PATCH 16/17] ABI: sysfs-driver-ufs: Add another What for platform drivers

[Avri Altman]

> On Wed, Sep 29, 2021 at 06:32:40AM +0000, Avri Altman wrote:
> > > The current what expressions:
> > >         What:          /sys/bus/platform/drivers/ufshcd/*/...
> > >
> > > Doesn't actually match what (some?) platform drivers actually
> > > export. For instance, drivers/scsi/ufs/ufs-hisi.c actually creates
> > > the sysfs struct for ufshcd inside this directory:
> > >
> > >         /sys/devices/platform/soc/ff3c0000.ufs
> > >
> > > Which has those aliases:
> > >
> > >         /sys/devices/virtual/devlink/platform:fff35000.crg_ctrl--
> > > platform:ff3c0000.ufs/consumer/
> > >         /sys/bus/platform/drivers/ufshcd-hisi/ff3c0000.ufs/
> > >         /sys/bus/platform/devices/soc/ff3c0000.ufs/
> > >         /sys/bus/platform/devices/ff3c0000.ufs/
> > >
> > > So, add another What: for such files that will match the device ufs
> > > entries, e. g.:
> > >
> > >         What:          /sys/bus/platform/devices/*.ufs/
> > On some platforms the suffix is .ufshc So Maybe use:
> > /sys/bus/platform/devices/*.ufs*/
> 
> That's confusing.  How about describing why "ufshc" is used in another
> entry?  You all must have picked the new name for some reason to
> differentiate, right?
It's a platform thing. Better let the platform guys answer that.

Thanks,
Avri

> 
> thanks,
> 
> greg k-h