Re: [PATCHv2 5/5] irqchip/GICv3: make reschedule-ipi light weight

[Pingfan Liu]

On Wed, Sep 29, 2021 at 08:24:34AM +0100, Marc Zyngier wrote:
> On Fri, 24 Sep 2021 14:28:37 +0100,
> Pingfan Liu <kernelfans@xxxxxxxxx> wrote:
> > 
> > To achieve the light weight as
> > DEFINE_IDTENTRY_SYSVEC_SIMPLE(sysvec_reschedule_ipi) on x86, it had
> > better treat irqnr differently at the frontend. And let IPI_RESCHEDULE
> > call __irq_enter_raw() instead of irq_enter_rcu().
> > 
> > Signed-off-by: Pingfan Liu <kernelfans@xxxxxxxxx>
> > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> > Cc: Will Deacon <will@xxxxxxxxxx>
> > Cc: Mark Rutland <mark.rutland@xxxxxxx>
> > Cc: Marc Zyngier <maz@xxxxxxxxxx>
> > Cc: Joey Gouly <joey.gouly@xxxxxxx>
> > Cc: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> > Cc: Julien Thierry <julien.thierry@xxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Yuichi Ito <ito-yuichi@xxxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > ---
> >  drivers/irqchip/irq-gic-v3.c | 15 +++++++++++++--
> >  1 file changed, 13 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> > index 906538fa8771..593d4539a209 100644
> > --- a/drivers/irqchip/irq-gic-v3.c
> > +++ b/drivers/irqchip/irq-gic-v3.c
> > @@ -709,6 +709,9 @@ static void gic_handle_nmi(struct pt_regs *regs)
> >  		gic_deactivate_unhandled(irqnr);
> >  }
> >  
> > +/* RESCHEDULE IPI hwirq nr is 0, and the only raw one */
> > +static unsigned long raw_interrupt_mask = 1;
> 
> I'm afraid you have the wrong end of the stick. This isn't a GIC
> property. This is an architecture decision, and only the architecture
> can expose what they want.
> 
Could it done be export an interface int (*get_irq_nr)(pte_regs) to
do_interrupt_handler()? So it can be seen as an architecture
decision.


Thanks,

	Pingfan
> 
> -- 
> Without deviation from the norm, progress is not possible.
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel