Re: [PATCH v6 3/6] dt-bindings: mvebu-uart: document DT bindings for marvell,armada-3700-uart-clock
From: Rob Herring
Date: Wed Sep 29 2021 - 17:30:11 EST
On Wed, Sep 29, 2021 at 04:01:32PM +0200, Pali Rohár wrote:
> On Wednesday 29 September 2021 08:46:25 Rob Herring wrote:
> > On Wed, 29 Sep 2021 10:20:31 +0200, Pali Rohár wrote:
> > > This change adds DT bindings documentation for device nodes with compatible
> > > string "marvell,armada-3700-uart-clock".
> > >
> > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> > >
> > > ---
> > > Changes in v6
> > > * Fix license
> > > * Rename node to clock-controller@12010
> > > * Remove maxItems
> > > ---
> > > .../bindings/clock/armada3700-uart-clock.yaml | 56 +++++++++++++++++++
> > > 1 file changed, 56 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: $id: 'http://devicetree.org/schemas/clock/marvell,armada-3700-uart-clock#' does not match 'http://devicetree.org/schemas/.*\\.yaml#'
> > from schema $id: http://devicetree.org/meta-schemas/base.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: 'maintainers' is a required property
> > hint: Metaschema for devicetree binding documentation
> > from schema $id: http://devicetree.org/meta-schemas/base.yaml#
> > ./Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: $id: relative path/filename doesn't match actual path or filename
> > expected: http://devicetree.org/schemas/clock/armada3700-uart-clock.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml: ignoring, error in schema: $id
> > warning: no schema found in file: ./Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml
> > Documentation/devicetree/bindings/clock/armada3700-uart-clock.example.dt.yaml:0:0: /example-0/clock-controller@12010: failed to match any schema with compatible: ['marvell,armada-3700-uart-clock']
>
> Hello! What does this error mean?
>
> Should I add .yaml suffix into '$id: ' line and rename file via?
> git mv Documentation/devicetree/bindings/clock/armada3700-uart-clock.yaml Documentation/devicetree/bindings/clock/marvell,armada-3700-uart-clock.yaml
Yes. They need to match.
Rob