Re: [PATCH 1/2] PCI: Use software node API with additional device properties

[Rafael J. Wysocki]

On Thu, Sep 30, 2021 at 12:20 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Thu, Sep 30, 2021 at 1:06 PM Heikki Krogerus
> <heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> > On Thu, Sep 30, 2021 at 10:33:27AM +0800, Zhangfei Gao wrote:
>
> ...
>
> > If the device is really never removed, then we could also constify the
> > node and the properties in it. Then the patch would look like this:
>
> I'm not sure the user can't force removal of the device (via PCI
> rescan, for example,, or via unbind/bind cycle).

The sysfs unbind doesn't remove the device, though, AFAICS.  It just
unbinds the driver from it, if any.

> I guess this way should be really taken carefully.

But I agree.