[hare-scsi-devel:scsi-result.v1 170/170] drivers/staging/unisys/visorhba/visorhba_main.c:383:10: error: 'struct scsi_cmnd' has no member named 'result'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git scsi-result.v1
head:   8b1a0adf66803c2d24951496a97bfe401d17b777
commit: 8b1a0adf66803c2d24951496a97bfe401d17b777 [170/170] scsi: split 'result' value into host_byte and status_byte
config: x86_64-randconfig-a006-20210929 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=8b1a0adf66803c2d24951496a97bfe401d17b777
        git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
        git fetch --no-tags hare-scsi-devel scsi-result.v1
        git checkout 8b1a0adf66803c2d24951496a97bfe401d17b777
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from include/scsi/scsi.h:12,
                    from drivers/staging/unisys/visorhba/visorhba_main.c:13:
   include/scsi/scsi_common.h: In function 'scsi_sense_buffer_valid':
   include/scsi/scsi_common.h:74:34: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
      74 |  return (sense_buffer[0] & 0x70) == 70;
         |                                  ^~
   drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_abort_handler':
>> drivers/staging/unisys/visorhba/visorhba_main.c:383:10: error: 'struct scsi_cmnd' has no member named 'result'
     383 |   scsicmd->result = DID_ABORT << 16;
         |          ^~
   drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_device_reset_handler':
   drivers/staging/unisys/visorhba/visorhba_main.c:410:10: error: 'struct scsi_cmnd' has no member named 'result'
     410 |   scsicmd->result = DID_RESET << 16;
         |          ^~
   drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_bus_reset_handler':
   drivers/staging/unisys/visorhba/visorhba_main.c:439:10: error: 'struct scsi_cmnd' has no member named 'result'
     439 |   scsicmd->result = DID_RESET << 16;
         |          ^~
   drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_serverdown_complete':
   drivers/staging/unisys/visorhba/visorhba_main.c:742:11: error: 'struct scsi_cmnd' has no member named 'result'
     742 |    scsicmd->result = DID_RESET << 16;
         |           ^~
   drivers/staging/unisys/visorhba/visorhba_main.c: In function 'complete_scsi_command':
   drivers/staging/unisys/visorhba/visorhba_main.c:904:9: error: 'struct scsi_cmnd' has no member named 'result'
     904 |  scsicmd->result = cmdrsp->scsi.linuxstat;
         |         ^~


vim +383 drivers/staging/unisys/visorhba/visorhba_main.c

d2c3506be646a4 David Kershner  2015-09-24  361  
c0487e7e83f136 David Binder    2017-02-21  362  /*
d2c3506be646a4 David Kershner  2015-09-24  363   * visorhba_abort_handler - Send TASK_MGMT_ABORT_TASK
d2c3506be646a4 David Kershner  2015-09-24  364   * @scsicmd: The scsicmd that needs aborted
d2c3506be646a4 David Kershner  2015-09-24  365   *
75f92fcda2923c David Binder    2017-06-30  366   * Return: SUCCESS if inserted, FAILED otherwise
d2c3506be646a4 David Kershner  2015-09-24  367   */
d2c3506be646a4 David Kershner  2015-09-24  368  static int visorhba_abort_handler(struct scsi_cmnd *scsicmd)
d2c3506be646a4 David Kershner  2015-09-24  369  {
d2c3506be646a4 David Kershner  2015-09-24  370  	/* issue TASK_MGMT_ABORT_TASK */
d2c3506be646a4 David Kershner  2015-09-24  371  	struct scsi_device *scsidev;
d2c3506be646a4 David Kershner  2015-09-24  372  	struct visordisk_info *vdisk;
7bc4e528d9f6fc Hannes Reinecke 2017-08-25  373  	int rtn;
d2c3506be646a4 David Kershner  2015-09-24  374  
d2c3506be646a4 David Kershner  2015-09-24  375  	scsidev = scsicmd->device;
7bc4e528d9f6fc Hannes Reinecke 2017-08-25  376  	vdisk = scsidev->hostdata;
d2c3506be646a4 David Kershner  2015-09-24  377  	if (atomic_read(&vdisk->error_count) < VISORHBA_ERROR_COUNT)
d2c3506be646a4 David Kershner  2015-09-24  378  		atomic_inc(&vdisk->error_count);
d2c3506be646a4 David Kershner  2015-09-24  379  	else
d2c3506be646a4 David Kershner  2015-09-24  380  		atomic_set(&vdisk->ios_threshold, IOS_ERROR_THRESHOLD);
7bc4e528d9f6fc Hannes Reinecke 2017-08-25  381  	rtn = forward_taskmgmt_command(TASK_MGMT_ABORT_TASK, scsidev);
7bc4e528d9f6fc Hannes Reinecke 2017-08-25  382  	if (rtn == SUCCESS) {
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 @383  		scsicmd->result = DID_ABORT << 16;
7bc4e528d9f6fc Hannes Reinecke 2017-08-25  384  		scsicmd->scsi_done(scsicmd);
d2c3506be646a4 David Kershner  2015-09-24  385  	}
7bc4e528d9f6fc Hannes Reinecke 2017-08-25  386  	return rtn;
d2c3506be646a4 David Kershner  2015-09-24  387  }
d2c3506be646a4 David Kershner  2015-09-24  388  

:::::: The code at line 383 was first introduced by commit
:::::: 7bc4e528d9f6fc4677eb1a4b0ddeb989c50e051d scsi: visorhba: sanitze private device data allocation

:::::: TO: Hannes Reinecke <hare@xxxxxxx>
:::::: CC: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip