Re: [PATCH v2] driver core: Reject pointless SYNC_STATE_ONLY device links

[Ulf Hansson]

On Wed, 29 Sept 2021 at 21:05, Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
>
> SYNC_STATE_ONLY device links intentionally allow cycles because cyclic
> sync_state() dependencies are valid and necessary.
>
> However a SYNC_STATE_ONLY device link where the consumer and the supplier
> are the same device is pointless because the device link would be deleted
> as soon as the device probes (because it's also the consumer) and won't
> affect when the sync_state() callback is called. It's a waste of CPU cycles
> and memory to create this device link. So reject any attempts to create
> such a device link.
>
> Fixes: 05ef983e0d65 ("driver core: Add device link support for SYNC_STATE_ONLY flag")
> Reported-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>

Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Kind regards
Uffe

> ---
> v1 -> v2:
> - Moved the check higher up in the function.
>
>  drivers/base/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 15986cc2fe5e..249da496581a 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -687,7 +687,8 @@ struct device_link *device_link_add(struct device *consumer,
>  {
>         struct device_link *link;
>
> -       if (!consumer || !supplier || flags & ~DL_ADD_VALID_FLAGS ||
> +       if (!consumer || !supplier || consumer == supplier ||
> +           flags & ~DL_ADD_VALID_FLAGS ||
>             (flags & DL_FLAG_STATELESS && flags & DL_MANAGED_LINK_FLAGS) ||
>             (flags & DL_FLAG_SYNC_STATE_ONLY &&
>              (flags & ~DL_FLAG_INFERRED) != DL_FLAG_SYNC_STATE_ONLY) ||
> --
> 2.33.0.685.g46640cef36-goog
>