Re: [PATCH v4 1/2] Revert "net: mdiobus: Fix memory leak in __mdiobus_register"

From: patchwork-bot+netdevbpf
Date: Thu Sep 30 2021 - 20:40:11 EST


Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Thu, 30 Sep 2021 20:49:42 +0300 you wrote:
> This reverts commit ab609f25d19858513919369ff3d9a63c02cd9e2e.
>
> This patch is correct in the sense that we _should_ call device_put() in
> case of device_register() failure, but the problem in this code is more
> vast.
>
> We need to set bus->state to UNMDIOBUS_REGISTERED before calling
> device_register() to correctly release the device in mdiobus_free().
> This patch prevents us from doing it, since in case of device_register()
> failure put_device() will be called 2 times and it will cause UAF or
> something else.
>
> [...]

Here is the summary with links:
- [v4,1/2] Revert "net: mdiobus: Fix memory leak in __mdiobus_register"
https://git.kernel.org/netdev/net/c/10eff1f5788b
- [v4,2/2] phy: mdio: fix memory leak
https://git.kernel.org/netdev/net/c/ca6e11c337da

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html