Re: [PATCH 1/3] usb: dwc2: add otg_rev and otg_caps information for gadget driver

[Minas Harutyunyan]

On 9/15/2021 11:54 AM, Fabrice Gasnier wrote:
> Currently the dwc2 doesn't fill in the 'otg_caps' of usb_gadget structure.
> When registering a gadget device (e.g. via configfs), the
> usb_otg_descriptor_init() checks the 'otg_caps' and 'otg_rev'. It defaults
> to HNP and SRP bmAttributes if unspecified. There may be a mismatch with
> what's being set in dwc2 params structure. This result in the descriptors
> to be miss-configured in this case.
> 
> So add an option to setup 'otg_caps' and 'otg_rev' in the params. It's
> then provided to the gadget struct. These parameters can then be tuned
> for each platform. In case it's not set, it will default to current
> behavior.
> Also add option to setup these from the device tree by calling
> of_usb_update_otg_caps(). This provides support for standard properties
> such as "otg-rev", "hnp-disable" and "srp-disable" (see usb-drd.yaml).
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
Acked-by: Minas Harutyunyan <Minas.Harutyunyan@xxxxxxxxxxxx>