Re: [PATCH] fs/9p: fix warnings found by checkpatch.pl

[Joe Perches]

On Fri, 2021-10-01 at 08:34 +0200, Sohaib Mohamed wrote:
> Signed-off-by: Sohaib Mohamed <sohaib.amhmd@xxxxxxxxx>

try using checkpatch on your proposed patch.

> diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h
[]
> @@ -135,8 +135,8 @@ static inline struct fscache_cookie *v9fs_inode_cookie(struct v9fs_inode *v9inod
>  
> 
>  extern int v9fs_show_options(struct seq_file *m, struct dentry *root);
>  
> 
> -struct p9_fid *v9fs_session_init(struct v9fs_session_info *, const char *,
> -									char *);
> +struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, const char
> +		*dev_name, char *data);

That's really not pretty as it separates the type of the 2nd argument.

Perhaps:

struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses,
				 const char *dev_name, char *data);