Re: [PATCH V6 5/8] x86/hyperv: Add Write/Read MSR registers via ghcb page

[Tianyu Lan]

On 10/1/2021 2:20 AM, Borislav Petkov wrote:
> On Thu, Sep 30, 2021 at 09:05:41AM -0400, Tianyu Lan wrote:
> > diff --git a/arch/x86/kernel/sev-shared.c b/arch/x86/kernel/sev-shared.c
> > index 9f90f460a28c..dd7f37de640b 100644
> > --- a/arch/x86/kernel/sev-shared.c
> > +++ b/arch/x86/kernel/sev-shared.c
> > @@ -94,10 +94,9 @@ static void vc_finish_insn(struct es_em_ctxt *ctxt)
> >   	ctxt->regs->ip += ctxt->insn.length;
> >   }
> >   
> > -static enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb,
> > -					  struct es_em_ctxt *ctxt,
> > -					  u64 exit_code, u64 exit_info_1,
> > -					  u64 exit_info_2)
> > +enum es_result sev_es_ghcb_hv_call_simple(struct ghcb *ghcb,
> > +				   u64 exit_code, u64 exit_info_1,
> > +				   u64 exit_info_2)
> Align arguments on the opening brace.
>
> Also, there's nothing "simple" about it - what you've carved out does
> the actual HV call and the trailing part is verifying the HV info. So
> that function should be called
>
> __sev_es_ghcb_hv_call()
>
> and the outer one without the "__".

Good suggestion. Will fix it in the next version.

Thanks.