[hare-scsi-devel:scsi-result.v1 170/170] drivers/staging/rts5208/rtsx.c:137:20: error: 'struct scsi_cmnd' has no member named 'result'

From: kernel test robot
Date: Fri Oct 01 2021 - 16:32:07 EST

tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git scsi-result.v1
head: 8b1a0adf66803c2d24951496a97bfe401d17b777
commit: 8b1a0adf66803c2d24951496a97bfe401d17b777 [170/170] scsi: split 'result' value into host_byte and status_byte
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=8b1a0adf66803c2d24951496a97bfe401d17b777
git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
git fetch --no-tags hare-scsi-devel scsi-result.v1
git checkout 8b1a0adf66803c2d24951496a97bfe401d17b777
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

In file included from include/linux/cdrom.h:16,
from drivers/staging/rts5208/rtsx.h:25,
from drivers/staging/rts5208/rtsx.c:17:
include/scsi/scsi_common.h: In function 'scsi_sense_buffer_valid':
include/scsi/scsi_common.h:74:41: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
74 | return (sense_buffer[0] & 0x70) == 70;
| ^~
drivers/staging/rts5208/rtsx.c: In function 'queuecommand_lck':
>> drivers/staging/rts5208/rtsx.c:137:20: error: 'struct scsi_cmnd' has no member named 'result'
137 | srb->result = DID_NO_CONNECT << 16;
| ^~
drivers/staging/rts5208/rtsx.c: In function 'rtsx_control_thread':
drivers/staging/rts5208/rtsx.c:380:34: error: 'struct scsi_cmnd' has no member named 'result'
380 | chip->srb->result = DID_ABORT << 16;
| ^~
drivers/staging/rts5208/rtsx.c:391:34: error: 'struct scsi_cmnd' has no member named 'result'
391 | chip->srb->result = DID_ERROR << 16;
| ^~
drivers/staging/rts5208/rtsx.c:401:34: error: 'struct scsi_cmnd' has no member named 'result'
401 | chip->srb->result = DID_BAD_TARGET << 16;
| ^~
drivers/staging/rts5208/rtsx.c:408:34: error: 'struct scsi_cmnd' has no member named 'result'
408 | chip->srb->result = DID_BAD_TARGET << 16;
| ^~
drivers/staging/rts5208/rtsx.c:425:35: error: 'struct scsi_cmnd' has no member named 'result'
425 | else if (chip->srb->result != DID_ABORT << 16) {
| ^~
drivers/staging/rts5208/rtsx.c: In function 'quiesce_and_remove_host':
drivers/staging/rts5208/rtsx.c:636:26: error: 'struct scsi_cmnd' has no member named 'result'
636 | chip->srb->result = DID_NO_CONNECT << 16;
| ^~
--
In file included from include/linux/cdrom.h:16,
from drivers/staging/rts5208/rtsx.h:25,
from drivers/staging/rts5208/rtsx_transport.c:16:
include/scsi/scsi_common.h: In function 'scsi_sense_buffer_valid':
include/scsi/scsi_common.h:74:41: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
74 | return (sense_buffer[0] & 0x70) == 70;
| ^~
drivers/staging/rts5208/rtsx_transport.c: In function 'rtsx_invoke_transport':
>> drivers/staging/rts5208/rtsx_transport.c:163:20: error: 'struct scsi_cmnd' has no member named 'result'
163 | srb->result = DID_ABORT << 16;
| ^~
drivers/staging/rts5208/rtsx_transport.c:170:20: error: 'struct scsi_cmnd' has no member named 'result'
170 | srb->result = DID_ERROR << 16;
| ^~
drivers/staging/rts5208/rtsx_transport.c:174:12: error: 'struct scsi_cmnd' has no member named 'result'
174 | srb->result = SAM_STAT_GOOD;
| ^~
drivers/staging/rts5208/rtsx_transport.c:183:20: error: 'struct scsi_cmnd' has no member named 'result'
183 | srb->result = SAM_STAT_CHECK_CONDITION;
| ^~


vim +137 drivers/staging/rts5208/rtsx.c

fa590c222fbaa42 Micky Ching 2013-11-12 106
fa590c222fbaa42 Micky Ching 2013-11-12 107 /***********************************************************************
fa590c222fbaa42 Micky Ching 2013-11-12 108 * /proc/scsi/ functions
fa590c222fbaa42 Micky Ching 2013-11-12 109 ***********************************************************************/
fa590c222fbaa42 Micky Ching 2013-11-12 110
fa590c222fbaa42 Micky Ching 2013-11-12 111 /* we use this macro to help us write into the buffer */
fa590c222fbaa42 Micky Ching 2013-11-12 112 #undef SPRINTF
fa590c222fbaa42 Micky Ching 2013-11-12 113 #define SPRINTF(args...) \
7e0ea476edb59f0 Wayne Porter 2016-10-11 114 do { \
7e0ea476edb59f0 Wayne Porter 2016-10-11 115 if (pos < buffer + length) \
7e0ea476edb59f0 Wayne Porter 2016-10-11 116 pos += sprintf(pos, ## args); \
7e0ea476edb59f0 Wayne Porter 2016-10-11 117 } while (0)
fa590c222fbaa42 Micky Ching 2013-11-12 118
fa590c222fbaa42 Micky Ching 2013-11-12 119 /* queue a command */
fa590c222fbaa42 Micky Ching 2013-11-12 120 /* This is always called with scsi_lock(host) held */
fa590c222fbaa42 Micky Ching 2013-11-12 121 static int queuecommand_lck(struct scsi_cmnd *srb,
fa590c222fbaa42 Micky Ching 2013-11-12 122 void (*done)(struct scsi_cmnd *))
fa590c222fbaa42 Micky Ching 2013-11-12 123 {
fa590c222fbaa42 Micky Ching 2013-11-12 124 struct rtsx_dev *dev = host_to_rtsx(srb->device->host);
fa590c222fbaa42 Micky Ching 2013-11-12 125 struct rtsx_chip *chip = dev->chip;
fa590c222fbaa42 Micky Ching 2013-11-12 126
fa590c222fbaa42 Micky Ching 2013-11-12 127 /* check for state-transition errors */
8bee668de51b7c5 Sandhya Bankar 2016-09-19 128 if (chip->srb) {
651cd163ba03807 Haneen Mohammed 2015-03-06 129 dev_err(&dev->pci->dev, "Error: chip->srb = %p\n",
651cd163ba03807 Haneen Mohammed 2015-03-06 130 chip->srb);
fa590c222fbaa42 Micky Ching 2013-11-12 131 return SCSI_MLQUEUE_HOST_BUSY;
fa590c222fbaa42 Micky Ching 2013-11-12 132 }
fa590c222fbaa42 Micky Ching 2013-11-12 133
fa590c222fbaa42 Micky Ching 2013-11-12 134 /* fail the command if we are disconnecting */
fa590c222fbaa42 Micky Ching 2013-11-12 135 if (rtsx_chk_stat(chip, RTSX_STAT_DISCONNECT)) {
fa590c222fbaa42 Micky Ching 2013-11-12 136 dev_info(&dev->pci->dev, "Fail command during disconnect\n");
fa590c222fbaa42 Micky Ching 2013-11-12 @137 srb->result = DID_NO_CONNECT << 16;
fa590c222fbaa42 Micky Ching 2013-11-12 138 done(srb);
fa590c222fbaa42 Micky Ching 2013-11-12 139 return 0;
fa590c222fbaa42 Micky Ching 2013-11-12 140 }
fa590c222fbaa42 Micky Ching 2013-11-12 141
fa590c222fbaa42 Micky Ching 2013-11-12 142 /* enqueue the command and wake up the control thread */
fa590c222fbaa42 Micky Ching 2013-11-12 143 srb->scsi_done = done;
fa590c222fbaa42 Micky Ching 2013-11-12 144 chip->srb = srb;
fa590c222fbaa42 Micky Ching 2013-11-12 145 complete(&dev->cmnd_ready);
fa590c222fbaa42 Micky Ching 2013-11-12 146
fa590c222fbaa42 Micky Ching 2013-11-12 147 return 0;
fa590c222fbaa42 Micky Ching 2013-11-12 148 }
fa590c222fbaa42 Micky Ching 2013-11-12 149

:::::: The code at line 137 was first introduced by commit
:::::: fa590c222fbaa428edb2ce2194638906cea1400a staging: rts5208: add support for rts5208 and rts5288

:::::: TO: Micky Ching <micky_ching@xxxxxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip