RE: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h

[Haiyang Zhang]

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Friday, October 1, 2021 9:56 AM
> To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>; linux-
> hyperv@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>;
> Wei Liu <wei.liu@xxxxxxxxxx>; Dexuan Cui <decui@xxxxxxxxxxxxx>; Greg
> Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Subject: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h
> 
> There is no user of anything in uuid.h in the hyperv.h. Replace it with
> more appropriate types.h.
> 
> Fixes: f081bbb3fd03 ("hyper-v: Remove internal types from UAPI header")
> Reported-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  include/uapi/linux/hyperv.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
> index 6135d92e0d47..daf82a230c0e 100644
> --- a/include/uapi/linux/hyperv.h
> +++ b/include/uapi/linux/hyperv.h
> @@ -26,7 +26,7 @@
>  #ifndef _UAPI_HYPERV_H
>  #define _UAPI_HYPERV_H
> 
> -#include <linux/uuid.h>
> +#include <linux/types.h>
> 
>  /*

Hyper-v drivers are using uuid/guid APIs, but they can get the defs from
linux/mod_devicetable.h:

./include/linux/mod_devicetable.h:#include <linux/uuid.h>
./include/linux/hyperv.h:#include <uapi/linux/hyperv.h>
./include/linux/hyperv.h:#include <linux/mod_devicetable.h>

So your patch looks fine. Thanks.

Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>