Re: [PATCH] af_unix: add missing annotation at bpf_iter_unix_seq_stop()

[Jakub Kicinski]

On Sat,  2 Oct 2021 00:49:37 +0100 Jules Irenge wrote:
> Sparse reports a warning at bpf_iter_unix_seq_stop()
> The root cause is a missing annotation at bpf_iter_unix_seq_stop()
> 
> Add the missing __releases(unix_table_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@xxxxxxxxx>
> ---
>  net/unix/af_unix.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
> index efac5989edb5..9838d4d855e0 100644
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -3291,6 +3291,7 @@ static int bpf_iter_unix_seq_show(struct seq_file *seq, void *v)
>  }
>  
>  static void bpf_iter_unix_seq_stop(struct seq_file *seq, void *v)
> +	__releases(unix_table_lock)
>  {
>  	struct bpf_iter_meta meta;
>  	struct bpf_prog *prog;

You need to CC bpf@vger... and netdev@vger...

You can drop the CC for linux-kernel@, approximately nobody reads that.