Re: [PATCH v1 1/1] seq_file: Move seq_escape() to a header

From: Andy Shevchenko
Date: Sat Oct 02 2021 - 03:58:20 EST


On Sat, Oct 2, 2021 at 2:41 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 1 Oct 2021 15:29:17 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > Move seq_escape() to the header as inliner.
>
> Some reason for doing this would be nice. Does it make the kernel
> smaller? Is this performance-sensitive?

It reduces exported namespace, hence makes it smaller, yes.

...

> > +#include <linux/string_helpers.h>
>
> Why was this added?

The definition of ESCAPE_OCTAL is there.

--
With Best Regards,
Andy Shevchenko