Re: [PATCH v10 03/28] x86/fpu/xstate: Modify state copy helpers to handle both static and dynamic buffers

[Bae, Chang Seok]

On Oct 1, 2021, at 05:47, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Wed, Aug 25 2021 at 08:53, Chang S. Bae wrote:
>> Have all the functions copying XSTATE take a struct fpu * pointer in
>> preparation for dynamic state buffer support.
> 
> Which is something different than the subject line claims to do and
> still does not explain why this code needs access to struct fpu later
> on.

This was liked by Boris [1]:

    What I would've written is:

    "Have all functions handling FPU state take a struct fpu * pointer in
     preparation for dynamic state buffer support."

    Plain and simple.

How about this (as similar to [2]):

    “To prepare dynamic features, change XSTATE copy functions' arguments to a
     struct fpu * pointer instead of a struct fpregs_state * pointer.  It will
     have new fields for dynamic features.”

Along with this title:

    “Prepare XSTATE copy functions to handle dynamic features”

Thanks,
Chang

[1] https://lore.kernel.org/lkml/20210115131802.GD11337@xxxxxxx/
[2]https://lore.kernel.org/lkml/5767911A-6F1F-4EDE-92A4-D4C3E5A3AABF@xxxxxxxxx/