Re: [PATCH] mm/hugetlb.c: remove dead store in demote_size_show()

[Mike Kravetz]

On 10/3/21 6:54 AM, Matthew Wilcox wrote:
> On Sun, Oct 03, 2021 at 06:41:13PM +0700, Nghia Le wrote:
>>  {
>>  	struct hstate *h;
>> -	unsigned long demote_size;
>>  	int nid;
>>  
>>  	h = kobj_to_hstate(kobj, &nid);
>> -	demote_size = h->demote_order;
>>  
>>  	return sysfs_emit(buf, "%lukB\n",
>>  			(unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K);
> 
> I'd suggest this function would look better written as:
> 
> 	int nid;
> 	struct hstate *h = kobj_to_hstate(kobj, &nid);
> 	unsigned long demote_size = (PAGE_SIZE << h->demote_order) / SZ_1K;
> 
> 	return sysfs_emit(buf, "%lukB\n", demote_size);
> 

Thank you Nghia Le for spotting this, and thank you Matthew for the
suggestion.

This is still just in Andrew's tree and subject to modification before
the next merge window.  I am still expecting additional comments on the
series.

If another version of the series is needed, I will include Matthew's
suggestion.   If not, I will ask Andrew how he would prefer to fold in
the changes.
-- 
Mike Kravetz