Re: [PATCH] ASoC: fsl: add COMPILE_TEST for SND_SOC_FSL_ASRC

[Geert Uytterhoeven]

Hi Randy,

On Sun, Oct 3, 2021 at 5:04 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> Geert pointed out that since sound/soc has the soc_dummy_driver for
> NO_DMA platforms, it is possible (desirable) to have drivers that
> depend on HAS_DMA to alternately depend on COMPILE_TEST.

Actually I had never heard about the soc_dummy_driver before ;-)
I did know about the dummies in include/linux/dma-mapping.h.

> This means that SND_ATMEL_FSL_ASRC can depend on HAS_DMA || COMPIE_TEST.

COMPILE_TEST

> Fixes: 121a01521b1e ("ASoC: fsl: fix build failure")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

> --- linux-next-20211001.orig/sound/soc/fsl/Kconfig
> +++ linux-next-20211001/sound/soc/fsl/Kconfig
> @@ -5,7 +5,7 @@ comment "Common SoC Audio options for Fr
>
>  config SND_SOC_FSL_ASRC
>         tristate "Asynchronous Sample Rate Converter (ASRC) module support"
> -       depends on HAS_DMA
> +       depends on HAS_DMA || COMPILE_TEST
>         select REGMAP_MMIO
>         select SND_SOC_GENERIC_DMAENGINE_PCM
>         help

The actual change LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds