[PATCH 5.4 35/56] debugfs: debugfs_create_file_size(): use IS_ERR to check for error
From: Greg Kroah-Hartman
Date: Mon Oct 04 2021 - 09:18:09 EST
From: Nirmoy Das <nirmoy.das@xxxxxxx>
commit af505cad9567f7a500d34bf183696d570d7f6810 upstream.
debugfs_create_file() returns encoded error so use IS_ERR for checking
return value.
Reviewed-by: Christian König <christian.koenig@xxxxxxx>
Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxx>
Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL")
Cc: stable <stable@xxxxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20210902102917.2233-1-nirmoy.das@xxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/debugfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/debugfs/inode.c
+++ b/fs/debugfs/inode.c
@@ -522,7 +522,7 @@ struct dentry *debugfs_create_file_size(
{
struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
- if (de)
+ if (!IS_ERR(de))
d_inode(de)->i_size = file_size;
return de;
}