Re: [PATCH] media: atomisp: fix `-Werror=return-type`

[Ammar Faizi]

On Mon, Oct 4, 2021 at 4:06 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> On Sun, Oct 03, 2021 at 06:17:23AM +0700, Ammar Faizi wrote:
> > Bedirhan reported build error:
> > ```
> >   drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
> >   drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
> >    1649 | }
> >         | ^
> >   cc1: some warnings being treated as errors
> >   make[4]: *** [scripts/Makefile.build:277: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o] Error 1
> >   make[3]: *** [scripts/Makefile.build:540: drivers/staging/media/atomisp] Error 2
> >   make[2]: *** [scripts/Makefile.build:540: drivers/staging/media] Error 2
> >   make[1]: *** [scripts/Makefile.build:540: drivers/staging] Error 2
> >   make: *** [Makefile:1868: drivers] Error 2
> > ```
> >
> > Commit 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp:
> > remove useless returns") incorrectly removed a required return results
> > in the above build error. Reinstate it.
> >
> > Cc: Pavel Skripkin <paskripkin@xxxxxxxxx>
> > Cc: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> > Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > Cc: linux-media@xxxxxxxxxxxxxxx
> > Cc: linux-staging@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Reported-by: Bedirhan KURT <windowz414@xxxxxxxxxxx>
> > Fixes: 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp: remove useless returns")
> > Signed-off-by: Ammar Faizi <ammar.faizi@xxxxxxxxxxxxxxxxxxxxx>
>
> What's going on with this?  It's like the seventh time people have sent
> a fix for it?  Why are you not using against a current tree?
>
> regards,
> dan carpenter
>

Sorry for the duplicate. It broke my build. I am using Linus' tree
5.15-rc4, the error still lives here. My mistake, I didn't check the
linux-next tree before sending this fix.

-- 
Ammar Faizi