Re: [PATCH V2 2/4] dt-bindings: arm: ti: am642/am654: Allow for SoC only compatibles

From: Rob Herring
Date: Mon Oct 04 2021 - 13:54:12 EST


On Sat, Sep 25, 2021 at 03:14:28PM -0500, Nishanth Menon wrote:
> Maintain consistency in K3 SoCs by allowing AM654 and AM642 platforms
> just state SoC compatibles without specific board specific compatibles
> aligned with what we have done for J721E/J7200 platforms as well.

This is the wrong direction IMO. Why do you want this other than
alignment?

>
> Signed-off-by: Nishanth Menon <nm@xxxxxx>
> ---
>
> Motivation to introduce in V2:
> * Retain consistency with both "soc only" and "board specific" as two
> schemes we support across k3.
>
> V1: did'nt exist
>
> .../devicetree/bindings/arm/ti/k3.yaml | 23 +++++++++++--------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> index cefb06424a4a..30c3f5c70014 100644
> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> @@ -20,12 +20,15 @@ properties:
> oneOf:
>
> - description: K3 AM654 SoC
> - items:
> - - enum:
> - - ti,am654-evm
> - - siemens,iot2050-basic
> - - siemens,iot2050-advanced
> + oneOf:
> - const: ti,am654
> + - items:
> + - enum:
> + - ti,am654-evm
> + - siemens,iot2050-basic
> + - siemens,iot2050-advanced
> + - const: ti,am654
> +
>
> - description: K3 J721E SoC
> oneOf:
> @@ -44,11 +47,13 @@ properties:
> - const: ti,j7200
>
> - description: K3 AM642 SoC
> - items:
> - - enum:
> - - ti,am642-evm
> - - ti,am642-sk
> + oneOf:
> - const: ti,am642
> + - items:
> + - enum:
> + - ti,am642-evm
> + - ti,am642-sk
> + - const: ti,am642
>
> additionalProperties: true
>
> --
> 2.32.0
>
>