Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault
From: Yang Shi
Date: Mon Oct 04 2021 - 14:17:45 EST
On Mon, Oct 4, 2021 at 7:06 AM Kirill A. Shutemov <kirill@xxxxxxxxxxxxx> wrote:
>
> On Thu, Sep 30, 2021 at 02:53:08PM -0700, Yang Shi wrote:
> > diff --git a/mm/filemap.c b/mm/filemap.c
> > index dae481293b5d..2acc2b977f66 100644
> > --- a/mm/filemap.c
> > +++ b/mm/filemap.c
> > @@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page)
> > }
> >
> > if (pmd_none(*vmf->pmd) && PageTransHuge(page)) {
> > - vm_fault_t ret = do_set_pmd(vmf, page);
> > - if (!ret) {
> > - /* The page is mapped successfully, reference consumed. */
> > - unlock_page(page);
> > - return true;
> > - }
> > + vm_fault_t ret = do_set_pmd(vmf, page);
> > + if (!ret) {
> > + /* The page is mapped successfully, reference consumed. */
> > + unlock_page(page);
> > + return true;
> > + }
> > }
> >
> > if (pmd_none(*vmf->pmd)) {
>
> Hm. Is it unrelated whitespace fix?
It is a coding style clean up. I thought it may be overkilling to have
a separate patch. Do you prefer separate one?
>
> --
> Kirill A. Shutemov