Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I
From: Kees Cook
Date: Mon Oct 04 2021 - 20:50:54 EST
On Mon, Oct 04, 2021 at 05:40:42PM -0700, Palmer Dabbelt wrote:
> On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@xxxxxxxxxxxx wrote:
> > On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote:
> > > The minimum supported version of GCC is now 5.1. The check wasn't
> > > correct as written anyways since GCC_VERSION is 0 when CC=clang.
> > >
> > > Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > > Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> > > Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> > > Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
> > > Signed-off-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> >
> > Yeah, good catch for Clang too.
> >
> > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Reviewed-by: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx>
> Acked-by: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx>
>
> Only this patch ended up in my inbox. Where you guys planning on keeping
> this whole series together, or did you want me to pick this for the RISC-V
> tree?
Linus already merged this series (see d20758951f8f28c0ee1b2a8a6bb8189858083895)
--
Kees Cook