Re: [PATCH v3 3/5] drm/msm/dp: Refactor ioremap wrapper
From: Bjorn Andersson
Date: Mon Oct 04 2021 - 21:17:58 EST
On Mon 04 Oct 18:04 PDT 2021, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2021-10-01 10:43:58)
> > In order to deal with multiple memory ranges in the following commit
> > change the ioremap wrapper to not poke directly into the dss_io_data
> > struct.
> >
> > While at it, devm_ioremap_resource() already prints useful error
> > messages on failure, so omit the unnecessary prints from the caller.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
>
> I realize this will cause some prints when we use old DTs. I suppose
> that's OK though because we'll have more incentive to update existing
> DT.
The use of the current binding is fairly limited, so I think that makes
sense. Abhinav also requested earlier that we do that and drop the
fallback sooner rather than later, which I would like to see as well.
Thanks,
Bjorn