Re: [PATCH 5.4 29/56] net: phy: bcm7xxx: request and manage GPHY clock

From: Greg Kroah-Hartman
Date: Tue Oct 05 2021 - 02:56:23 EST


On Mon, Oct 04, 2021 at 01:35:40PM -0700, Florian Fainelli wrote:
> On 10/4/21 5:52 AM, Greg Kroah-Hartman wrote:
> > From: Florian Fainelli <f.fainelli@xxxxxxxxx>
> >
> > [ Upstream commit ba4ee3c053659119472135231dbef8f6880ce1fb ]
> >
> > The internal Gigabit PHY on Broadcom STB chips has a digital clock which
> > drives its MDIO interface among other things, the driver now requests
> > and manage that clock during .probe() and .remove() accordingly.
> >
> > Because the PHY driver can be probed with the clocks turned off we need
> > to apply the dummy BMSR workaround during the driver probe function to
> > ensure subsequent MDIO read or write towards the PHY will succeed.
> >
> > Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> > Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> Please drop this patch from the queue, this is not a bug fix for the 5.4
> branch. If you would like me to send a patch for "net: phy: bcm7xxx:
> Fixed indirect MMD operations", please let me know.

I have dropped both of these now. If you think the second commit needs
to be in the 5.4.y tree, please send a backport.

thanks,

greg k-h