Re: [PATCH v2 RESEND] mfd: hi6421-spmi-pmic: cleanup drvdata

[Mauro Carvalho Chehab]

Em Tue, 5 Oct 2021 09:11:06 +0100
Lee Jones <lee.jones@xxxxxxxxxx> escreveu:

> On Tue, 05 Oct 2021, Mauro Carvalho Chehab wrote:
> 
> > Em Tue, 5 Oct 2021 08:50:50 +0100
> > Lee Jones <lee.jones@xxxxxxxxxx> escreveu:
> >   
> > > On Wed, 15 Sep 2021, Mauro Carvalho Chehab wrote:
> > >   
> > > > There are lots of fields at struct hi6421_spmi_pmic that aren't
> > > > used. In a matter of fact, only regmap is needed.
> > > > 
> > > > So, drop the struct as a hole, and set just the regmap as
> > > > the drvdata.
> > > > 
> > > > Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> > > > ---
> > > >  drivers/mfd/hi6421-spmi-pmic.c           | 16 +++++----------
> > > >  drivers/misc/hi6421v600-irq.c            |  9 ++++-----
> > > >  drivers/regulator/hi6421v600-regulator.c | 10 +++++-----
> > > >  include/linux/mfd/hi6421-spmi-pmic.h     | 25 ------------------------
> > > >  4 files changed, 14 insertions(+), 46 deletions(-)
> > > >  delete mode 100644 include/linux/mfd/hi6421-spmi-pmic.h    
> > > 
> > > For my own reference (apply this as-is to your sign-off block):
> > > 
> > >   Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > > 
> > > I intend to take this with a Misc Ack.  
> > 
> > Hi Lee,
> > 
> > Greg already gave you:
> > 
> > 	https://lore.kernel.org/all/YVLA14jbwqXjNM2f@xxxxxxxxx/  
> 
> Yes, I found that after I replied to this one.
> 
> I was having some trouble applying it with `b4` just as you replied:
> 
>   https://lore.kernel.org/tools/CAF2Aj3icJtU+wacosM-LO2aqMChWL69T6bf7dK3xqPMSk6Ux3w@xxxxxxxxxxxxxx/T/#u

Weird. Yeah, getting acks are sometimes problematic. I remember
having issues with that (a long time ago) with patchwork too.

> I fixed the spelling/grammar mistakes and applied the patch.

Thank you!

Best regards,
Mauro