Re: [PATCH v1 1/1] usb: dwc3: gadget: Revert "set gadgets parent to the right controller"

From: Felipe Balbi
Date: Tue Oct 05 2021 - 06:50:16 EST



Michael Grzeschik <mgr@xxxxxxxxxxxxxx> writes:

> [[PGP Signed Part:Undecided]]
> On Mon, Oct 04, 2021 at 10:35:57PM +0200, Ferry Toth wrote:
>>Hi,
>>
>>Op 04-10-2021 om 16:18 schreef Andy Shevchenko:
>>>The commit c6e23b89a95d ("usb: dwc3: gadget: set gadgets parent to the right
>>>controller") changed the device for the UDC and broke the user space scripts
>>>that instantiate the USB gadget(s) via ConfigFS.
>>
>> I confirm this regression on Intel Edison since at least 5.15-rc2
>> while in 5.14.0 it was working fine.
>>
>>This patch resolves the issue as tested on 5.15-rc4.
>>
>>Tested-by: Ferry Toth<fntoth@xxxxxxxxx>
>
> NACK! Why should we resolv an issue by reverting it to solve not working
> userspace. We already have this patch as a solution for solving a deeper

heh, there is only one rule in this community: thou shalt not break
userspace :-)

--
balbi