Re: [PATCH v5 1/2] dt-bindings: clk: qcom: Document MSM8976 Global Clock Controller

From: Rob Herring
Date: Tue Oct 05 2021 - 08:26:53 EST


On Mon, 04 Oct 2021 21:52:54 +0200, Marijn Suijten wrote:
> Document the required properties and firmware clocks for gcc-msm8976 to
> operate nominally, and add header definitions for referencing the clocks
> from firmware.
>
> Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
> ---
> .../bindings/clock/qcom,gcc-msm8976.yaml | 95 +++++++
> include/dt-bindings/clock/qcom,gcc-msm8976.h | 240 ++++++++++++++++++
> 2 files changed, 335 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8976.yaml
> create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8976.h
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/qcom,gcc-msm8976.example.dt.yaml: clock-controller@1800000: 'vdd_gfx-supply' is a required property
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/clock/qcom,gcc-msm8976.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1536345

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.