Re: [PATCH] ASoC: qcom: soundwire: Enable soundwire bus clock for version 1.6

From: Pierre-Louis Bossart
Date: Tue Oct 05 2021 - 11:05:23 EST




>>> +        ctrl->swrm_hctl_reg = devm_ioremap(&pdev->dev,
>>> swrm_hctl_reg, 0x4);
>> if (!ctrl->swrm_hctl_reg)
>>      return -ENODEV;
>>
>> ?
> I think here error check is not required, as this change is required
> only for soundwire version 1.6 and above.

My comment had nothing to do with versions, it's just that ioremap can
fail and in general it's wise to test for errors...