Re: [PATCH v10 1/3] mm: rearrange madvise code to allow for reuse

[Liam Howlett]

* Suren Baghdasaryan <surenb@xxxxxxxxxx> [211004 12:18]:
> On Mon, Oct 4, 2021 at 12:03 AM Rolf Eike Beer <eb@xxxxxxxxx> wrote:
> >
> > > --- a/mm/madvise.c
> > > +++ b/mm/madvise.c
> > > @@ -63,76 +63,20 @@ static int madvise_need_mmap_write(int behavior)
> > >  }
> > >
> > >  /*
> > > - * We can potentially split a vm area into separate
> > > - * areas, each area with its own behavior.
> > > + * Update the vm_flags on regiion of a vma, splitting it or merging it as
> >                                 ^^
> 
> Thanks! Will fix in the next version.

Since you'll be respinning for this comment, can you please point out
that the split will keep the VMA as [vma->vm_start, new_end)?  That is,
__split_vma() is passed 0 for new_below.  It might prove useful since
the code is being reused.

Thanks,
Liam

> 
> >
> > Eike
> > --
> > Rolf Eike Beer, emlix GmbH, http://www.emlix.com
> > Fon +49 551 30664-0, Fax +49 551 30664-11
> > Gothaer Platz 3, 37083 Göttingen, Germany
> > Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
> > Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055
> >
> > emlix - smart embedded open source
> >
> > --
> > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@xxxxxxxxxxx.
>