Re: [PATCH v4 4/6] dm: add add_disk() error handling

From: Mike Snitzer
Date: Wed Oct 06 2021 - 09:17:57 EST


On Mon, Sep 27 2021 at 5:59P -0400,
Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote:

> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> There are two calls to dm_setup_md_queue() which can fail then,
> one on dm_early_create() and we can easily see that the error path
> there calls dm_destroy in the error path. The other use case is on
> the ioctl table_load case. If that fails userspace needs to call
> the DM_DEV_REMOVE_CMD to cleanup the state - similar to any other
> failure.
>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
> Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

Reviewed-by: Mike Snitzer <snitzer@xxxxxxxxxx>