[PATCH] hashtable: remove a redundant check in hash_for_each_xxx()

From: Wei Yang
Date: Wed Oct 06 2021 - 11:21:53 EST


The three hash_for_each_xxx() helper iterate the hash table with help
of hlist_for_each_entry_xxx(), which breaks the loop only when obj is
NULL.

This means the check during each iteration is redundant. This patch
removes it.

Signed-off-by: Wei Yang <richard.weiyang@xxxxxxxxx>
---
include/linux/hashtable.h | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/include/linux/hashtable.h b/include/linux/hashtable.h
index f6c666730b8c..a15719ed303f 100644
--- a/include/linux/hashtable.h
+++ b/include/linux/hashtable.h
@@ -124,8 +124,7 @@ static inline void hash_del_rcu(struct hlist_node *node)
* @member: the name of the hlist_node within the struct
*/
#define hash_for_each(name, bkt, obj, member) \
- for ((bkt) = 0, obj = NULL; obj == NULL && (bkt) < HASH_SIZE(name);\
- (bkt)++)\
+ for ((bkt) = 0, obj = NULL; (bkt) < HASH_SIZE(name); (bkt)++) \
hlist_for_each_entry(obj, &name[bkt], member)

/**
@@ -136,8 +135,7 @@ static inline void hash_del_rcu(struct hlist_node *node)
* @member: the name of the hlist_node within the struct
*/
#define hash_for_each_rcu(name, bkt, obj, member) \
- for ((bkt) = 0, obj = NULL; obj == NULL && (bkt) < HASH_SIZE(name);\
- (bkt)++)\
+ for ((bkt) = 0, obj = NULL; (bkt) < HASH_SIZE(name); (bkt)++) \
hlist_for_each_entry_rcu(obj, &name[bkt], member)

/**
@@ -150,8 +148,7 @@ static inline void hash_del_rcu(struct hlist_node *node)
* @member: the name of the hlist_node within the struct
*/
#define hash_for_each_safe(name, bkt, tmp, obj, member) \
- for ((bkt) = 0, obj = NULL; obj == NULL && (bkt) < HASH_SIZE(name);\
- (bkt)++)\
+ for ((bkt) = 0, obj = NULL; (bkt) < HASH_SIZE(name); (bkt)++) \
hlist_for_each_entry_safe(obj, tmp, &name[bkt], member)

/**
--
2.23.0